Open
Conversation
DavidParks8
suggested changes
Feb 26, 2026
| /// </remarks> | ||
| internal sealed class HybridCacheSessionStore : ISessionStore | ||
| { | ||
| private static readonly TimeSpan DefaultSessionTimeout = TimeSpan.FromMinutes(15); |
Contributor
There was a problem hiding this comment.
This is way too short. Please change to at least double that.
| ### Minimal Redis Configuration | ||
|
|
||
| ```csharp | ||
| using Azure.Identity; |
Contributor
There was a problem hiding this comment.
These docs are a bit too azure-y. They should be kept generic. Also, they are missing the WithSessionAffinity call.
Directory.Packages.props
Outdated
| <PackageVersion Include="System.Linq.AsyncEnumerable" Version="$(System10Version)" /> | ||
| <PackageVersion Include="xunit.v3" Version="3.2.2" /> | ||
| <PackageVersion Include="xunit.runner.visualstudio" Version="3.1.5" /> | ||
| <PackageVersion Include="NSubstitute" Version="5.3.0" /> |
Contributor
There was a problem hiding this comment.
They already have moq in this repo. I wouldn't be surprised if they wanted us to keep using that instead of NSubstitute.
…csharp-sdk into mcp.core.distributed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Added ModelContextProtocol.AspNetCore.Distributed library
#828
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context